Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add account, aggregate, node, file essential Functionality #177

Merged
merged 13 commits into from
Nov 16, 2023

Conversation

1yam
Copy link
Collaborator

@1yam 1yam commented Nov 14, 2023

Problem:

  • Lot's of basic features was missing on Aleph CLI

Solution:

  • Add those features:

    Account:

    • aleph account balance -> return current user balance or specific with --address

    File:

    • aleph file list -> return user file or specific of a specific address with --address
    • aleph file forget -> forget a file

    Aggregate:

    • aleph aggregate post (used for update too)
    • aleph aggregate get

    Node:

    • Compute:
      • aleph node compute -> List all compute nodes
    • Core:
      • aleph node core -> List all core channel nodes

1yam added 4 commits November 14, 2023 13:49
Solutions:
- aleph node core -> show all core node
- aleph node compute -> show all compute node
Solutions:
- aleph account balance -> get current user balance
- aleph account balance --address {add} -> get specific address balance
Solutions:
- aleph file list
- aleph file forget
Solutions:
- aleph aggregate post
- aleph aggregate amend
- aleph aggregate get
Solution:
- Add types-requests lib
Copy link
Member

@MHHukiewitz MHHukiewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very important features, right here. A few things need attention though.

src/aleph_client/commands/aggregate.py Outdated Show resolved Hide resolved
src/aleph_client/commands/files.py Outdated Show resolved Hide resolved
src/aleph_client/commands/files.py Show resolved Hide resolved
src/aleph_client/commands/files.py Outdated Show resolved Hide resolved
src/aleph_client/commands/node.py Outdated Show resolved Hide resolved
1yam and others added 8 commits November 15, 2023 12:49
Solutions:
- Amend command wasn't needed (can simply use post to update an aggregate)
Solutions:
- Add a Rich Table for a nicer output.
- Allow the user to use --export-json to get JSON instead of a rich table.
Solutions:
- Replace --export_json by --json for more simple use
Solutions:

-Allow user to export as json instead of rich table using --json
@MHHukiewitz MHHukiewitz merged commit f836c8f into aleph-im:master Nov 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants