-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add account, aggregate, node, file essential Functionality #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solutions: - aleph node core -> show all core node - aleph node compute -> show all compute node
Solutions: - aleph account balance -> get current user balance - aleph account balance --address {add} -> get specific address balance
Solutions: - aleph file list - aleph file forget
Solutions: - aleph aggregate post - aleph aggregate amend - aleph aggregate get
MHHukiewitz
requested changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very important features, right here. A few things need attention though.
Co-authored-by: Mike Hukiewitz <[email protected]>
Co-authored-by: Mike Hukiewitz <[email protected]>
Co-authored-by: Mike Hukiewitz <[email protected]>
Solutions: - Amend command wasn't needed (can simply use post to update an aggregate)
Solutions: - Add a Rich Table for a nicer output. - Allow the user to use --export-json to get JSON instead of a rich table.
Solutions: - Replace --export_json by --json for more simple use
Solutions: -Allow user to export as json instead of rich table using --json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
Add those features:
Account:
aleph account balance
-> return current user balance or specific with--address
File:
aleph file list
-> return user file or specific of a specific address with--address
aleph file forget
-> forget a fileAggregate:
aleph aggregate post
(used for update too)aleph aggregate get
Node:
aleph node compute
-> List all compute nodesaleph node core
-> List all core channel nodes