Feature: Cli download commands aleph & ipfs #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
requested changes
Jul 13, 2023
src/aleph_client/commands/files.py
Outdated
| if not use_ipfs: | ||
| file_content = client.download_file(item_hash) | ||
| else: | ||
| file_content = client.download_file_ipfs(item_hash) |
There was a problem hiding this comment.
You can now use download_file_to_buffer to reduce memory usage.
src/aleph_client/commands/utils.py
Outdated
| write content of file download to byte into a path | ||
| """ | ||
| file_path = Path(path) | ||
| file_path.write_bytes(content) |
There was a problem hiding this comment.
This function will be useless once you use download_file_to_buffer.
MHHukiewitz
requested changes
Nov 9, 2023
| @@ -7,6 +7,7 @@ | |||
| from pygments.lexers import JsonLexer | |||
| from typer import echo | |||
| from datetime import datetime | |||
| from pathlib import Path | |||
| @@ -122,3 +123,4 @@ def str_to_datetime(date: Optional[str]) -> Optional[datetime]: | |||
| except ValueError: | |||
| pass | |||
| return datetime.fromisoformat(date) | |||
|
|
|||
| @@ -15,4 +15,4 @@ def test_get_message_type_value(): | |||
| assert get_message_type_value(AggregateMessage) == MessageType.aggregate | |||
| assert get_message_type_value(StoreMessage) == MessageType.store | |||
| assert get_message_type_value(ProgramMessage) == MessageType.program | |||
| assert get_message_type_value(ForgetMessage) == MessageType.forget | |||
| assert get_message_type_value(ForgetMessage) == MessageType.forget | |||
There was a problem hiding this comment.
seems also unneeded? Maybe it's due to auto formatting
MHHukiewitz
reviewed
Nov 10, 2023
| if path is None: | ||
| path = item_hash | ||
|
|
||
| with AlephClient(api_server=sdk_settings.API_HOST) as client: |
There was a problem hiding this comment.
This is the wrong import, try using async with AlephHttpClient
|
Closing this PR and will be superseded by a fresh branch. GH seems to not handle some of the rebases/force-pushes well that happened here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solutions: