Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cross-platform desyncs #1

Merged
merged 5 commits into from
Dec 15, 2023
Merged

fix cross-platform desyncs #1

merged 5 commits into from
Dec 15, 2023

Conversation

aleksa2808
Copy link
Owner

@aleksa2808 aleksa2808 commented Dec 13, 2023

Native and WASM builds could not play together without immediately running into desyncs. This PR fixes several sources of desyncs to enable cross platform play, including:

  • switching the checksum hashing to a portable implementation
  • switching the random number generator to a portable implementation
  • replacing many instances of usize and isize with explicitly sized types

@aleksa2808 aleksa2808 closed this Dec 13, 2023
@aleksa2808 aleksa2808 deleted the fix-platform-determinism branch December 13, 2023 23:02
@aleksa2808 aleksa2808 restored the fix-platform-determinism branch December 13, 2023 23:02
@aleksa2808 aleksa2808 reopened this Dec 13, 2023
@aleksa2808 aleksa2808 changed the title improve rng generator determinism fix cross-platform desyncs Dec 13, 2023
@aleksa2808 aleksa2808 merged commit 668406c into master Dec 15, 2023
2 checks passed
@aleksa2808 aleksa2808 deleted the fix-platform-determinism branch December 15, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant