Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

add dependabot support for npm and go dependencies #1347

Merged
merged 7 commits into from
Oct 31, 2022
Merged

Conversation

uncledru
Copy link
Contributor

@uncledru uncledru commented Oct 26, 2022

Description

Adds dependabot support to corso/src (go).
Adds dependabot support to corso/website (npm).
Adds dependabot support to corso/docs (npm).

Adds dependabot support to corso for actions as well.

Warning that dependabot emails can get noisy so everyone may need to add email rules/update repository notifications 😭

PR limit of 5 here to test and we can increase as needed. Working well in ark. Increased to 50 w/ auto-merge.

Type of change

Please check the type of change your PR introduces:

  • 🌻 Feature
  • 🐛 Bugfix
  • 🗺️ Documentation
  • 🤖 Test
  • 🐹 Trivial/Minor
  • 💰 Tech Debt

Linear Issue(s)

  • Fixes ALC-541

Test Plan

Merge and see what happens (no way to currently test dependabot config).

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E
  • ❌ TEST IN PROD 👀

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2022

CLA assistant check
All committers have signed the CLA.

@uncledru uncledru temporarily deployed to Testing October 26, 2022 19:39 Inactive
@uncledru uncledru requested review from bchex and qt1p October 26, 2022 19:39
@uncledru uncledru temporarily deployed to Testing October 26, 2022 19:40 Inactive
@uncledru uncledru temporarily deployed to Testing October 28, 2022 13:51 Inactive
@uncledru uncledru temporarily deployed to Testing October 28, 2022 13:51 Inactive
@uncledru uncledru temporarily deployed to Testing October 28, 2022 14:02 Inactive
@uncledru uncledru marked this pull request as ready for review October 28, 2022 14:02
@uncledru uncledru temporarily deployed to Testing October 28, 2022 14:02 Inactive
@uncledru uncledru requested a review from a team October 28, 2022 14:02
@uncledru uncledru temporarily deployed to Testing October 28, 2022 14:03 Inactive
@uncledru uncledru temporarily deployed to Testing October 28, 2022 14:03 Inactive
@uncledru uncledru temporarily deployed to Testing October 28, 2022 14:23 Inactive
@uncledru uncledru temporarily deployed to Testing October 28, 2022 14:23 Inactive
@uncledru uncledru temporarily deployed to Testing October 28, 2022 14:23 Inactive
@uncledru uncledru temporarily deployed to Testing October 28, 2022 14:23 Inactive
@uncledru uncledru temporarily deployed to Testing October 28, 2022 14:23 Inactive
@uncledru uncledru temporarily deployed to Testing October 28, 2022 14:39 Inactive
Copy link
Contributor

@ashmrtn ashmrtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question: we want to have full control over the upgrade of some of our go dependencies (the ms graph code and Kopia come to mind). Sometimes upgrading these could cause things to break in ways that can only be discovered with more thorough testing outside of CI. Will this interfere with that?

@uncledru
Copy link
Contributor Author

Quick question: we want to have full control over the upgrade of some of our go dependencies (the ms graph code and Kopia come to mind). Sometimes upgrading these could cause things to break in ways that can only be discovered with more thorough testing outside of CI. Will this interfere with that?

Great question! Yes, it would update those dependencies.

If we agree that critical dependencies should only be updated manually - I can tell dependabot to ignore those deps.

@ashmrtn
Copy link
Contributor

ashmrtn commented Oct 28, 2022

If we agree that critical dependencies should only be updated manually - I can tell dependabot to ignore those deps.

@vkamra @dadams39 should we add kopia and all the ms graph stuff to the ignore list?

@vkamra
Copy link
Contributor

vkamra commented Oct 28, 2022

If we agree that critical dependencies should only be updated manually - I can tell dependabot to ignore those deps.

@vkamra @dadams39 should we add kopia and all the ms graph stuff to the ignore list?

Yep - let's just remove automerge on go dependencies for now please.

@uncledru uncledru temporarily deployed to Testing October 29, 2022 01:05 Inactive
@uncledru uncledru temporarily deployed to Testing October 29, 2022 01:19 Inactive
on:
pull_request:
paths-ignore:
- "src/**" # prevent auto-merge for go dependencies
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately auto-merge config does not support ignore options.

paths-ignore prevents the auto-merge action from running for go dependencies under src/.

image

Copy link
Contributor

@vkamra vkamra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - there's one comment to look at please

schedule:
interval: "weekly"
reviewers:
- "alcion/platform"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be Corso maintainers?

@uncledru uncledru temporarily deployed to Testing October 30, 2022 15:42 Inactive
@uncledru uncledru temporarily deployed to Testing October 30, 2022 15:42 Inactive
@uncledru uncledru changed the title [Minor][ALC-541] add dependabot support for npm and go dependencies add dependabot support for npm and go dependencies Oct 30, 2022
@uncledru uncledru temporarily deployed to Testing October 30, 2022 15:44 Inactive
@uncledru uncledru temporarily deployed to Testing October 30, 2022 15:44 Inactive
@uncledru uncledru temporarily deployed to Testing October 30, 2022 15:45 Inactive
@uncledru uncledru temporarily deployed to Testing October 30, 2022 15:45 Inactive
@uncledru uncledru temporarily deployed to Testing October 30, 2022 15:45 Inactive
@uncledru uncledru temporarily deployed to Testing October 30, 2022 16:09 Inactive
@uncledru uncledru temporarily deployed to Testing October 31, 2022 13:22 Inactive
@uncledru uncledru temporarily deployed to Testing October 31, 2022 13:22 Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@uncledru uncledru temporarily deployed to Testing October 31, 2022 13:23 Inactive
@uncledru uncledru temporarily deployed to Testing October 31, 2022 13:23 Inactive
@uncledru uncledru temporarily deployed to Testing October 31, 2022 13:23 Inactive
@uncledru uncledru temporarily deployed to Testing October 31, 2022 13:44 Inactive
@uncledru uncledru merged commit 813b719 into main Oct 31, 2022
@uncledru uncledru deleted the feat/dependabot branch October 31, 2022 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants