Mappers Part 1 #167
Merged
Mappers Part 1 #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the codebase a bit. Not yet showing the benefit, but Soon (tm)
…s instead of passed as an argument, making it more of a side-effect
depombo
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started work on the refactoring RFC. Today's progress is just using it as a thin wrapper on top of the GPT calling logic and doesn't really provide a benefit.
Next steps will be creating Mappers for the other transformations in the codebase and moving most of the logic out of
llm.py, reviving the stats tracking logic (probably automatically within theChatGPTMapper), and then pulling logic out ofbase.pyintollm.pyand start refactoring said logic into the layers of transformations.This PR is fully functional (besides the stats tracking, which shouldn't be too hard) and could be merged once stats are back, but it could also be a longer-lived branch if we want to wait for the RFC to be merged first.