[Core] Discard empty strings in file paths

Backport #518 to the release branch. Patch thanks to issueg2k4g34j2g
alanmcgovern · Mar 27, 2022 · 2d5c67c · 2d5c67c
1 parent 4deac15
commit 2d5c67c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/MonoTorrent.Tests/Common/TorrentTest.cs b/src/MonoTorrent.Tests/Common/TorrentTest.cs
@@ -99,6 +99,8 @@ private BEncodedList CreateFiles ()
             BEncodedList files = new BEncodedList ();
 
             BEncodedList path = new BEncodedList {
+                new BEncodedString (""),
+                new BEncodedString (""),
                 new BEncodedString ("file1.txt")
             };
 

diff --git a/src/MonoTorrent/MonoTorrent/Torrent.cs b/src/MonoTorrent/MonoTorrent/Torrent.cs
@@ -210,8 +210,10 @@ IList<TorrentFile> LoadTorrentFiles (BEncodedList list)
 
                         case ("path.utf-8"):
                             foreach (BEncodedString str in ((BEncodedList) keypair.Value)) {
-                                sb.Append (str.Text);
-                                sb.Append (Path.DirectorySeparatorChar);
+                                if (!BEncodedString.IsNullOrEmpty (str)) {
+                                    sb.Append (str.Text);
+                                    sb.Append (Path.DirectorySeparatorChar);
+                                }
                             }
                             path = sb.ToString (0, sb.Length - 1);
                             sb.Remove (0, sb.Length);
@@ -220,8 +222,10 @@ IList<TorrentFile> LoadTorrentFiles (BEncodedList list)
                         case ("path"):
                             if (string.IsNullOrEmpty (path)) {
                                 foreach (BEncodedString str in ((BEncodedList) keypair.Value)) {
-                                    sb.Append (str.Text);
-                                    sb.Append (Path.DirectorySeparatorChar);
+                                    if (!BEncodedString.IsNullOrEmpty (str)) {
+                                        sb.Append (str.Text);
+                                        sb.Append (Path.DirectorySeparatorChar);
+                                    }
                                 }
                                 path = sb.ToString (0, sb.Length - 1);
                                 sb.Remove (0, sb.Length);