Pre post cleanup callbacks #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Alan,
Thanks very much for storage-atom, I have used it a whole bunch in the last few years.
This patch adds two optional callback functions
pre-clean-fnandpost-clean-fn. These callbacks allow the user to clean the value before it is written to storage and on the way out after it is read from storage. The first callback takes the value and the second one takes the outgoing value and it's previous value (if any). If there is anything you want me to do or if I can improve this patch in any way do let me know.PS I was not able to run the tests using
boot test-cljsas an error occurred:java.lang.ClassNotFoundException: javax.xml.bind.DatatypeConverter, compiling:(cljs/closure.clj:1:1)Fixes #20.