Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add styles files and added dark mode implementation (#186) #200

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maliksenpai
Copy link

#186

I'm not sure about the dark and light theme css files but if you want I can update this pr.

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for bulletproof-react-app ready!

Name Link
🔨 Latest commit 71bc52b
🔍 Latest deploy log https://app.netlify.com/sites/bulletproof-react-app/deploys/66cb22d130dd150008dc44de
😎 Deploy Preview https://deploy-preview-200--bulletproof-react-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alan2207
Copy link
Owner

Hey @maliksenpai , this is a very nice addition, thanks for contributing. Currently, it doesn't look ideal on all pages where some colors are hardcoded though, If you can make it look nice on all pages I will be more than happy to merge this... 🚀

@maliksenpai
Copy link
Author

@alan2207 Thank you for your kind words, but I didn't understand very well. Should I proceed by adding style files one by one for all pages? If so, should I add the codes I wrote in PR to all these style files?

@alan2207
Copy link
Owner

@maliksenpai I was referring to the dark mode. Some components are not made to work with it, if you have the time, feel free to update them so they are compatible with light/dark mode.
There is no need for the .css files though since all styling is done via Tailwind, a single style file is sufficient.

@maliksenpai
Copy link
Author

maliksenpai commented Aug 22, 2024

Okay I understand, I will review and update whether all components support dark mode or not. And I will delete themes .css files. I will work on ASAP.

@alan2207

@maliksenpai
Copy link
Author

hey @alan2207 I checked every page for dark mode and fixed all UI bugs. You can check it if you want, there may be points I missed (but I hope not).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants