Added functionality #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now detects any clipboard changes ,deletion being the main focus . Use case being ,for example, a password manager such as keepass and its auto-delete password from clipboard function.
aksdb
reviewed
Apr 2, 2023
| s.mtx.Lock() | ||
|
|
||
| // Keep checking for clipboard changes on the host machine | ||
| for { |
There was a problem hiding this comment.
This doesn't seem to have any exit condition. Previously, when we closed the clipboard, the watcher channel would be closed as well, therefore exiting the loop.
There was a problem hiding this comment.
True , mb. Also i noticed that i want two things going at the same time and is making my brain work. If i wanted to notify the client that it may need to wait should i ask it to wait a set amount of time then ? Unless it gets updated then it just restarts the loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now detects any clipboard changes ,deletion being the main focus . Use case being ,for example, a password manager such as keepass and its auto-delete password from clipboard function.