Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for sb_rand and sb_memory and supported parameters extension for memory test #455

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

evvoevod
Copy link

@evvoevod evvoevod commented Jun 6, 2022

First commit fixes critical bug in sb_rand which broke Gaussian distribution due to 'rand_iter' initialized to zero after Special distribution has got dropped.
Second commit extends supported --memory-total-size and --memory-block-size parameters values allowing total size to be smaller than block size. This allows another level of control of benchmarking to the user.
Third commit provides support of periodic statistics in memory tests which is not supported currently. It allows to periodically report throughput during memory test run. On the other hand it decreases benchmark throughput roughly by 5% depending on access type and distribution used and underlying hardware.
Fourth commit extends sb_rand to use 64-bits variables and functions parameters which allows to use --memory-block-size values larger than 16GB.

…' distribution has been dropped

Zero initialized rand_iter variable led to zero offset returnd by
sb_rand_gaussian function resulting in broken gaussian distribution
accessing only index 0 in the workset array
@evvoevod
Copy link
Author

evvoevod commented Jun 29, 2022

@akopytov ping...

@zincentimeter
Copy link

zincentimeter commented Jul 15, 2023

I faced the broken gaussian problem today and it took me a very great time to get down to the root cause:( Hope this PR can get into main stream ASAP.

@evvoevod
Copy link
Author

@akopytov, could you please review these patches? Random memory access patterns are broken.

1 similar comment
@evvoevod
Copy link
Author

evvoevod commented Aug 6, 2024

@akopytov, could you please review these patches? Random memory access patterns are broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants