Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember-ajax to version 3.0.0 🚀 #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

greenkeeperio-bot
Copy link

Hello lovely humans,

ember-ajax just published its new version 3.0.0.

State Update 🚀
Dependency ember-ajax
New version 3.0.0
Type devDependency

This version is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of ember-ajax.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


GitHub Release

Breaking Changes

Simplifying normalizeErrorResponse

After much discussion, the team around ember-ajax decided that it was probably not a great idea to reformat the error payload to match some arbitrary format that we designed. Instead, we should just use the payload that the server returned.

If you want to maintain the old behavior, you can include the the legacy/normalize-error-response mixin, which has the old version of the method included and will override the new behavior.

// app/services/ajax.js
import AjaxService from 'ember-ajax/services/ajax';
import LegacyNormalizeErrorResponse from 'ember-ajax/mixins/legacy/normalize-error-response';

export default AjaxService.extends(LegacyNormalizeErrorResponse, {
// Your other configuration here
});

Replacing AjaxError.errors with AjaxError.payload

The errors property on any AjaxError subclass has been deprecated in favor of a payload property for a while now. If you want access to the response from the server, you should now use the payload property, like so:

return this.get('ajax').request('/posts')
  .then((posts) => {
    // Do something with your posts
  })
  .catch((error) => {
    this.displayError(error.payload); // `error.payload` will be whatever the server responded with
  });

No longer modify null or undefined server response (#232)

If your server response is interpreted by jQuery#ajax to be null or undefined, we will resolve that value, instead of turning it into an empty object.


The new version differs by 126 commits .

  • 2aba19e Released v3.0.0
  • 5c6a45a Upgrade dependencies (#283)
  • acd384f fix(package): update ember-cli-babel to version 6.0.0-beta.10 (#277)
  • c70bc9a Update to use Babel 6 (#266)
  • 528e843 Upgrade ember-resolver to 4.1.0
  • 4181656 Released v3.0.0-beta.1
  • 86ab8d0 Fix issues with the isString helper
  • 723dd66 Tighten ESLint config
  • 78de692 Hide container by default when running tests
  • ac023c1 Slight cleanup of JSON test helper
  • 60cb8de make sure contentType is a string before running a regex match (#250)
  • 4e784a2 Released v3.0.0-beta.0
  • fe03044 Released v2.5.7-beta.0
  • db086b3 Released v2.5.7
  • 1f4ca9d Simplify normalizeErrorResponse (#265)

There are 126 commits in total. See the full diff.


✨ Try the all new Greenkeeper GitHub Integration
With Integrations first-class bot support landed on GitHub and we’ve rewritten Greenkeeper to take full advantage of it. Simpler setup, fewer pull-requests, faster than ever.

Screencast

Try it today. Free for private repositories during beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants