Port scala akka PR #26816 to Akka.NET #4511

Arkatufus · 2020-07-10T23:28:43Z

Related to #4419
Port of akka/akka#26816

Arkatufus · 2020-07-10T23:35:55Z

I'm having problem with this port, the port passes a scala ExecutionContext into the ActorSystem factory, and this ExecutionContext trickles down into the MessageDispatcher to be used inside the thread pool.
Problem is, I can't really emulate this with C#.
Any help will be greatly appreciated.

Arkatufus · 2020-07-10T23:43:16Z

ActorSystem.Create() --> ActorSystemImpl() --> DefaultDispatcherPrerequisites().
Prerequisites object is then injected into the thread executor factory to be used as a configurator for each thread instantiation.

Arkatufus · 2020-07-13T20:11:05Z

Should `Akka.Cluster.Metric" and "Akka.Remote" use internal dispatcher too?

… Akka.Stream

Aaronontheweb

Overall looks good, but have some important changes that need to be made.

Aaronontheweb · 2020-07-20T16:20:45Z

docs/articles/actors/dispatchers.md

+
+## Dispatcher aliases
+
+When a dispatcher is looked up, and the given setting contains a string rather than a dispatcher config block, 


Aaronontheweb · 2020-07-20T16:21:16Z

src/contrib/cluster/Akka.Cluster.Sharding/ClusterSharding.cs

@@ -262,7 +262,7 @@ public ClusterSharding(ExtendedActorSystem system)
            {
                var guardianName = system.Settings.Config.GetString("akka.cluster.sharding.guardian-name");
                var dispatcher = system.Settings.Config.GetString("akka.cluster.sharding.use-dispatcher");
-                if (string.IsNullOrEmpty(dispatcher)) dispatcher = Dispatchers.DefaultDispatcherId;
+                if (string.IsNullOrEmpty(dispatcher)) dispatcher = Dispatchers.InternalDispatcherId;


LGTM - looks like all of the sharding /system actors (the guardians and coordinators) are supposed to run on the internal dispatcher

Aaronontheweb · 2020-07-20T16:21:33Z

src/contrib/cluster/Akka.Cluster.Tools/Client/ClusterClientReceptionist.cs

@@ -133,7 +133,7 @@ private IActorRef CreateReceptionist()
            {
                var name = _config.GetString("name");
                var dispatcher = _config.GetString("use-dispatcher", null);
-                if (string.IsNullOrEmpty(dispatcher)) dispatcher = Dispatchers.DefaultDispatcherId;
+                if (string.IsNullOrEmpty(dispatcher)) dispatcher = Dispatchers.InternalDispatcherId;


Aaronontheweb · 2020-07-20T16:22:06Z

src/contrib/cluster/Akka.Cluster.Tools/Singleton/ClusterSingletonManager.cs

@@ -604,7 +605,9 @@ public static Props Props(Props singletonProps, ClusterSingletonManagerSettings
        /// <returns>TBD</returns>
        public static Props Props(Props singletonProps, object terminationMessage, ClusterSingletonManagerSettings settings)
        {
-            return Actor.Props.Create(() => new ClusterSingletonManager(singletonProps, terminationMessage, settings)).WithDeploy(Deploy.Local);
+            return Actor.Props.Create(() => new ClusterSingletonManager(singletonProps, terminationMessage, settings))
+                .WithDispatcher(Dispatchers.InternalDispatcherId)


Aaronontheweb · 2020-07-20T16:22:14Z

src/contrib/cluster/Akka.Cluster.Tools/Singleton/ClusterSingletonProxy.cs

@@ -70,7 +71,9 @@ public static Config DefaultConfig()
        /// <returns>TBD</returns>
        public static Props Props(string singletonManagerPath, ClusterSingletonProxySettings settings)
        {
-            return Actor.Props.Create(() => new ClusterSingletonProxy(singletonManagerPath, settings)).WithDeploy(Deploy.Local);
+            return Actor.Props.Create(() => new ClusterSingletonProxy(singletonManagerPath, settings))
+                .WithDispatcher(Dispatchers.InternalDispatcherId)


Aaronontheweb · 2020-07-21T15:16:33Z

src/core/Akka.Streams.Tests/Dsl/UnfoldResourceAsyncSourceSpec.cs

@@ -293,7 +293,7 @@ public void A_UnfoldResourceAsyncSource_must_use_dedicated_blocking_io_dispatche
                    var actorRef = refs.First(@ref => @ref.Path.ToString().Contains("unfoldResourceSourceAsync"));
                    try
                    {
-                        Utils.AssertDispatcher(actorRef, "akka.stream.default-blocking-io-dispatcher");
+                        Utils.AssertDispatcher(actorRef, ActorAttributes.IODispatcher.Name);


Aaronontheweb · 2020-07-21T15:17:28Z

src/core/Akka.Streams/ActorMaterializer.cs

@@ -336,7 +336,7 @@ private static ActorMaterializerSettings Create(Config config)
                streamRefSettings: StreamRefSettings.Create(config.GetConfig("stream-ref")));
        }

-        private const int DefaultlMaxFixedbufferSize = 1000;
+        private const int DefaultMaxFixedBufferSize = 1000;


Aaronontheweb · 2020-07-21T15:37:44Z

src/core/Akka.Tests/Actor/ActorSystemDispatcherSpec.cs

+        [Fact]
+        public void The_ActorSystem_must_provide_a_good_error_on_a_dispatcher_alias_loop_in_config()
+        {
+            Sys.Dispatchers.Invoking(d => d.Lookup("dispatcher-loop-1"))


Aaronontheweb · 2020-07-21T16:13:39Z

src/core/Akka/Configuration/Pigeon.conf

+        task-peeking-mode = "FIFO"
+
+
+        dedicated-thread-pool{ #settings for Helios.DedicatedThreadPool
            thread-count = 3 #number of threads


We might need to adjust this too.... The dedicated threadpool sized might interfere with these settings on the ForkJoinExecutor

src/core/Akka/Helios.Concurrency.DedicatedThreadPool.cs

Aaronontheweb · 2020-07-23T19:21:04Z

LGTM

src/core/Akka/Actor/ActorRefProvider.cs

Aaronontheweb · 2020-08-19T18:28:57Z

Putting this on hold until we've completed #4537

Aaronontheweb · 2020-10-05T21:20:16Z

Should `Akka.Cluster.Metric" and "Akka.Remote" use internal dispatcher too?

I need to check if Akka.Remote should use the same internal dispatcher - that's critical enough where it might merit having its own threads still.

Port scala akka PR #26816 to Akka.NET

91adfb9

Arkatufus marked this pull request as draft July 10, 2020 23:29

Arkatufus changed the title ~~Port scala akka PR #26816 to Akka.NET~~ [WIP] Port scala akka PR #26816 to Akka.NET Jul 10, 2020

Arkatufus added 2 commits July 14, 2020 01:21

Remove SynchronizationContext usage

9a7a041

Use internal dispatcher in other part of Akka.NET, update documentation

ff7d06a

Arkatufus added 4 commits July 15, 2020 01:08

Port internal blocking dispatcher and default internal dispatcher for…

d9a0e9c

… Akka.Stream

Add circular dispatcher alias reference checking, unroll recursion

1d6e588

Make ClusterSingletonManager and Proxy to use internal dispatchers

9acb12a

Update API approver list

e76172b

Arkatufus marked this pull request as ready for review July 14, 2020 22:02

Arkatufus changed the title ~~[WIP] Port scala akka PR #26816 to Akka.NET~~ Port scala akka PR #26816 to Akka.NET Jul 14, 2020

Arkatufus added 3 commits July 15, 2020 05:15

Merge branch 'dev' into Port_#26816_Internal_dispatcher

14ce58b

Merge branch 'dev' into Port_#26816_Internal_dispatcher

9d7ebb1

Merge branch 'dev' into Port_#26816_Internal_dispatcher

7af7a15

Aaronontheweb self-requested a review July 17, 2020 14:12

Arkatufus and others added 2 commits July 18, 2020 04:03

Merge branch 'dev' into Port_#26816_Internal_dispatcher

5fe55d4

Merge branch 'dev' into Port_#26816_Internal_dispatcher

cc99809

Aaronontheweb requested changes Jul 21, 2020

View reviewed changes

Arkatufus added 3 commits July 22, 2020 00:05

Remove SynchronizationContext

32a0736

Clean up Pigeon.conf config file

8f8f6f0

Merge branch 'dev' into Port_#26816_Internal_dispatcher

c7237bf

Aaronontheweb mentioned this pull request Jul 21, 2020

How prevent "Scheduled sending of heartbeat was delayed" and occasionally network partitions #4432

Closed

Merge branch 'dev' into Port_#26816_Internal_dispatcher

f6745fa

Aaronontheweb approved these changes Jul 23, 2020

View reviewed changes

Aaronontheweb reviewed Jul 30, 2020

View reviewed changes

src/core/Akka/Actor/ActorRefProvider.cs Show resolved Hide resolved

Aaronontheweb mentioned this pull request Aug 5, 2020

DedicatedThreadPool Performance Optimization #4537

Closed

Aaronontheweb added the on hold label Aug 19, 2020

Merge branch 'dev' into Port_#26816_Internal_dispatcher

00884de

Aaronontheweb added akka-actor and removed on hold labels Oct 5, 2020

Merge branch 'dev' into Port_#26816_Internal_dispatcher

eea49ff

Aaronontheweb merged commit a80ddd7 into akkadotnet:dev Oct 6, 2020

Aaronontheweb mentioned this pull request Oct 6, 2020

How force akka system run on its own threadpool and mixed used of cluster client #4419

Closed

This was referenced Oct 26, 2020

Need to validate that its fine to have Akka.Remote use system dispatcher #4589

Closed

Akka.Remote + ForkJoinExecutor dispatcher configuration changes #4597

Closed

Arkatufus deleted the Port_#26816_Internal_dispatcher branch March 8, 2021 13:32

Aaronontheweb mentioned this pull request Apr 1, 2021

Akka.Cluster: quarantining / reachability changes appear to be extremely sensitive #4849

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port scala akka PR #26816 to Akka.NET #4511

Port scala akka PR #26816 to Akka.NET #4511

Arkatufus commented Jul 10, 2020

Arkatufus commented Jul 10, 2020

Arkatufus commented Jul 10, 2020

Arkatufus commented Jul 13, 2020

Aaronontheweb left a comment

Aaronontheweb Jul 20, 2020

Aaronontheweb Jul 20, 2020

Aaronontheweb Jul 20, 2020

Aaronontheweb Jul 20, 2020

Aaronontheweb Jul 20, 2020

Aaronontheweb Jul 21, 2020

Aaronontheweb Jul 21, 2020

Aaronontheweb Jul 21, 2020

Aaronontheweb Jul 21, 2020

Aaronontheweb commented Jul 23, 2020

Aaronontheweb commented Aug 19, 2020

Aaronontheweb commented Oct 5, 2020


		## Dispatcher aliases

		When a dispatcher is looked up, and the given setting contains a string rather than a dispatcher config block,

Port scala akka PR #26816 to Akka.NET #4511

Port scala akka PR #26816 to Akka.NET #4511

Conversation

Arkatufus commented Jul 10, 2020

Arkatufus commented Jul 10, 2020

Arkatufus commented Jul 10, 2020

Arkatufus commented Jul 13, 2020

Aaronontheweb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Aaronontheweb commented Jul 23, 2020

Aaronontheweb commented Aug 19, 2020

Aaronontheweb commented Oct 5, 2020