Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove fixme for grpc client in EventProducerPush #993

Merged
merged 1 commit into from
Sep 7, 2023
Merged

chore: remove fixme for grpc client in EventProducerPush #993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...ection-grpc/src/main/scala/akka/projection/grpc/producer/scaladsl/EventProducerPush.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ final class EventProducerPush[Event](

def handler()(implicit system: ActorSystem[_])
: FlowWithContext[EventEnvelope[Event], ProjectionContext, Done, ProjectionContext, NotUsed] = {
// FIXME gprc client config - use stream id to look up block? Use host to lookup port (normal gRPC client config)? Something else?
// users doing it themselves may be fine?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think user can do the GrpcClientSettings.fromConfig rather than we have a separate config section with stream-id entries.

val eventConsumerClient = EventConsumerServiceClient(grpcClientSettings)
EventPusher(originId, eventConsumerClient, eventProducerSource, connectionMetadata.getOrElse(MetadataBuilder.empty))
}
Expand Down
Loading