feat: Convenience filter all consumer filter #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
reviewed
Aug 28, 2023
| * Exclude events from all entity ids, convenience for combining with for example a topic filter | ||
| * to include only events matching the topic filter. | ||
| */ | ||
| val filterAll = ExcludeRegexEntityIds(Set(".*")) |
There was a problem hiding this comment.
excludeAll ?
filterAll is somewhat ambiguous if it's include or exclude
There was a problem hiding this comment.
Good point, I always need to check scala collection filter vs filterNot...
patriknw
approved these changes
Aug 29, 2023
akka-projection-grpc/src/main/scala/akka/projection/grpc/consumer/ConsumerFilter.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.