Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: grpc sample restaurant order replication #963

Merged
merged 6 commits into from
Aug 29, 2023

Conversation

johanandren
Copy link
Member

@johanandren johanandren commented Aug 24, 2023

Central cloud accepts setting up restaurants and their locations, then registering deliveries per restaurant, the delivery orders are then replicated to the right local drone control where a drone can get assigned the closest by order on request.

implicit val timeout: Timeout = settings.askTimeout

// initial consumer topic filter for location id
// FIXME no docs of setting up initial consumer filter, am I missing some API?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johanandren johanandren marked this pull request as ready for review August 28, 2023 12:45
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

"delivery-events",
// location id already is in the format of a topic filter expression
Vector(
ConsumerFilter.ExcludeRegexEntityIds(Set(".*")),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can use the new excludeAll, and include filter in GrpcReadJournal constructor

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, but not until we made a milestone with those

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanandren johanandren merged commit bd40f50 into main Aug 29, 2023
25 checks passed
@johanandren johanandren deleted the wip-restaurant-order-replication branch August 29, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants