Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve performance on WSL2 #504

Merged
merged 6 commits into from
Sep 22, 2024
Merged

Conversation

musou1500
Copy link
Contributor

@musou1500 musou1500 commented Sep 21, 2024

This PR fixes performance issue on WSL described in #96

Copy link
Owner

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this issue. I believe this issue should be fixed in the upstream WSL2, but we probably need to adjust it on our side since they don't seem to be going to fix it.

I'd like to check also [[ :$PATH: == *:/mnt/*:* ]] to determine the use of this workaround because there doesn't seem to be performance degradation as far as /mnt/* is not present in PATH.

lib/core-complete.sh Outdated Show resolved Hide resolved
lib/core-complete.sh Outdated Show resolved Hide resolved
lib/core-complete.sh Outdated Show resolved Hide resolved
lib/core-complete.sh Outdated Show resolved Hide resolved
lib/core-complete.sh Outdated Show resolved Hide resolved
ble.pp Outdated Show resolved Hide resolved
@akinomyoga
Copy link
Owner

I'd like to check also [[ :$PATH: == *:/mnt/*:* ]] to determine the use of this workaround because there doesn't seem to be performance degradation as far as /mnt/* is not present in PATH.

Have you noticed this part?

@musou1500
Copy link
Contributor Author

thank you. I'll additional check for [[ :$PATH: == *:/mnt/*:* ]].
If my understand is correct, condition will be "using wsl and $PATH includes /mnt".
is it correct?

@akinomyoga
Copy link
Owner

That's right.

@musou1500
Copy link
Contributor Author

I made change that checks $PATH and confirmed performance issue is fixed !

Copy link
Owner

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

lib/core-complete.sh Outdated Show resolved Hide resolved
@akinomyoga akinomyoga merged commit 0914a11 into akinomyoga:master Sep 22, 2024
4 checks passed
@akinomyoga
Copy link
Owner

I've merged it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants