Skip to content

Commit

Permalink
main: shorten the startup message for debug versions with init command
Browse files Browse the repository at this point in the history
  • Loading branch information
akinomyoga committed Jul 29, 2024
1 parent 51e762f commit 0bc8610
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 6 deletions.
2 changes: 1 addition & 1 deletion ble.pp
Original file line number Diff line number Diff line change
Expand Up @@ -2291,7 +2291,7 @@ function ble/base/check-bash-debug-version {
local sgr3=${_ble_term_setaf[2]}
local sgrC=${_ble_term_setaf[8]}
local bold=$_ble_term_bold
if [[ $type == short ]]; then
if [[ $type == short || $_ble_init_command ]]; then
ble/util/print-lines \
"Note: ble.sh can be very slow in a debug version of Bash: $sgr3$BASH_VERSION$sgr0"
else
Expand Down
11 changes: 6 additions & 5 deletions docs/ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- util(joblist): exclude more foreground dead jobs in Bash 5.3 `#D2174` 8a321424
- global: work around function names with slashes in Bash 5.3 POSIX mode `#D2221` 48c7bbee
- main: update the startup message for debug versions of Bash `#D2222` afb29073
- main: shorten the startup message for debug versions `#D2241` xxxxxxxx
- decode(read-user-settings): read the colonless form of `bind -x` of Bash 5.3 `#D2233` 62b23b69
- bgproc: support opts `kill9-timeout=TIMEOUT` `#D2034` 3ab41652
- progcomp(cd): change display name and support mandb desc (requested by EmilySeville7cfg) `#D2039` 74402098
Expand Down Expand Up @@ -115,7 +116,7 @@
- keymap/vi: fix <kbd>C-w</kbd> not saving the word into kill ring `#D2208` aa7ca45d
- edit: fix standard streams in `EXIT` trap with `ble/widget/exit` `#D2217` 89f0dab8
- util(`ble/fd#cloexec`): check `fdflags` compatibility to avoid crash `#D2227` c3b3aaf8
- util(`ble/function#evaldef`): suppress alias expansions (reported by 103sbavert) `#D2240` xxxxxxxx
- util(`ble/function#evaldef`): suppress alias expansions (reported by 103sbavert) `#D2240` 51e762fe

## Compatibility

Expand Down Expand Up @@ -160,7 +161,7 @@
- mandb: support man page format of `rg` (requested by pallaswept) `#D2225` 063bf66b
- mandb: restore ASCII hyphens from Unicode hyphens before analysis (reported by pallaswept) `#D2230` f160b8f0
- main: work around the issue WSL clears `/tmp` after Bash starts (reported by LeonardoMor) `#D2235` fcbf1ed0
- decode(`ble/builtin/bind`): support single quotes in the macro/command strings `#D2236` xxxxxxxx
- decode(`ble/builtin/bind`): support single quotes in the macro/command strings `#D2236` 2f90120e

## Contrib

Expand All @@ -180,9 +181,9 @@
- contrib/config/execmark: output error status through `ble/canvas/trace` `#D2136` 64cdcd01
- contrib/airline: remove dummy faces (reported by alexalekseyenko) `#D2204` 59787ee5
- contrib/airline: update themes `#D2204` 59787ee5
- contrib/fzf-git: fix unadjusted terminal states in calling `fzf` (reported by tessus) `#D2237` xxxxxxxx
- contrib/bash-preexec: support `__bp_set_ret_value` (requested by Comnenus) `#D2238` xxxxxxxx
- contrib/colorglass: fix fixed-point round `#D2239` xxxxxxxx
- contrib/fzf-git: fix unadjusted terminal states in calling `fzf` (reported by tessus) `#D2237` b154058a
- contrib/bash-preexec: support `__bp_set_ret_value` (requested by Comnenus) `#D2238` b154058a
- contrib/colorglass: fix fixed-point round `#D2239` b154058a

## Documentation

Expand Down
13 changes: 13 additions & 0 deletions note.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7394,6 +7394,19 @@ bash_tips

2024-07-29

* main: --clear-cache で長々しい devel version では遅い warning を出力する必要はあるのか [#D2241]
Ref. #D2222

この長い version のメッセージを実装した時に意図的にそうしたのだったか? 或い
は余り考えていなかったのか? → 確認してみたが別に余り考えていなかった様だ。
新しく _ble_init_command が指定されていた時には長いメッセージの代わりに短い
メッセージを表示する事にした。

オプション --bash-debug-version=check を明示的に指定した時には長いものを表
示する事も考えたが、"long" ではなくて "check" だし、諸々の処理をする時に長
いメッセージを表示する必要もない気がするので、check を明示した場合でもやは
り短いメッセージを表示する事にする。

* util(ble/function#pop): エイリアス展開により push/pop の度に関数がどんどん長くなる (reported by 103sbavert) [#D2240]
https://github.com/akinomyoga/ble.sh/issues/471

Expand Down

0 comments on commit 0bc8610

Please sign in to comment.