Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations and refactor #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Delmael
Copy link

@Delmael Delmael commented Jan 16, 2025

Hi @ajtudela
Sounds way better !

I was working on translation and saw you've done the es part. The fr translation is in this MR.
There is also some refactor for entities (and tests updates for it).

Thanks

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.13%. Comparing base (ded81c7) to head (789471d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   96.44%   96.13%   -0.32%     
==========================================
  Files           9       10       +1     
  Lines         788      724      -64     
==========================================
- Hits          760      696      -64     
  Misses         28       28              
Files with missing lines Coverage Δ
custom_components/smartbox/__init__.py 85.18% <100.00%> (ø)
custom_components/smartbox/climate.py 97.11% <100.00%> (-0.28%) ⬇️
custom_components/smartbox/config_flow.py 80.59% <100.00%> (-0.57%) ⬇️
custom_components/smartbox/entity.py 100.00% <100.00%> (ø)
custom_components/smartbox/model.py 98.90% <100.00%> (ø)
custom_components/smartbox/number.py 100.00% <100.00%> (ø)
custom_components/smartbox/sensor.py 98.96% <100.00%> (-0.24%) ⬇️
custom_components/smartbox/switch.py 100.00% <100.00%> (ø)

@ajtudela
Copy link
Owner

Thanks, I'll try to review this evening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants