Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor and upgrade the Sidebar component #310

Merged
merged 4 commits into from
Oct 2, 2024
Merged

feat: refactor and upgrade the Sidebar component #310

merged 4 commits into from
Oct 2, 2024

Conversation

stone-lyl
Copy link
Collaborator

  • feat: relocate left sidebar to the right side
  • feat: increase sidebar width
Before After
❌ ✅
image image
  • feat: set addNode mode as default in the sidebar
  • feat: Implement overlay functionality for the sidebar
sidebar-overly.mp4

@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
data-story-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 2:10am

ajthinking
ajthinking approved these changes Oct 1, 2024
View reviewed changes
Copy link
Owner

@ajthinking ajthinking left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good 🙌
One minor thing: I think keeping the controls to the left would give it a more "fixed" feeling, so they always stay in the same place when toggling sidebar.
image

@ajthinking
Copy link
Owner

Related, possibly out of scope for this PR:
consider sidebar styles when having little horizontal space to work with.
image

@stone-lyl
Copy link
Collaborator Author

  • feat: relocate the right sidebar to the left side
  • feat: adjust minimum size constraint for sidebar
minsize-sidebar.mp4

@ajthinking ajthinking merged commit 546607b into ajthinking:main Oct 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajthinking ajthinking ajthinking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stone-lyl @ajthinking