Be careful about Pathnames in $LOAD_PATH

ajbouh · Jul 22, 2016 · 4f2727b · 4f2727b
1 parent ca38e09
commit 4f2727b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/qa/runner-assets/ruby/shared.rb b/src/qa/runner-assets/ruby/shared.rb
@@ -752,7 +752,7 @@ def summarize_exception(error, backtrace, message=nil)
     # ]
 
     backtrace_bindings = error.instance_variable_get(:@__qa_caller_bindings)
-    load_path = $LOAD_PATH
+    load_path = $LOAD_PATH.map(&:to_s)
 
     backtrace = backtrace.each_with_index.map do |entry, index|
       entry =~ /(.+?):(\d+)(?:\:in `(.*)')?/ || (next nil)

diff --git a/src/qa_test/fixtures/ruby/all-outcomes/spec/error_spec.rb b/src/qa_test/fixtures/ruby/all-outcomes/spec/error_spec.rb
@@ -1,3 +1,8 @@
+# Try to pollute LOAD_PATH.
+require 'pathname'
+
+$LOAD_PATH.push(Pathname.new("foo"))
+
 RSpec.describe "Error" do
   context "world of errors" do
     it "always errors" do