Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocommit precommit changes #1840

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Autocommit precommit changes #1840

merged 2 commits into from
Oct 8, 2024

Conversation

kumaranvpl
Copy link
Contributor

Description

Pre-commit can fail with two types of errors - 1. auto fixable(linting, codespell, etc), 2. manually fixable(mypy, semgrep, etc).
We can auto commit changes only if the failure is because of 1. auto fixable failure.

@Lancetnik I took an approach here where I run the auto fixable hooks alone first, commit next and then run everything again.

There could be an alternative approach too. Run everything first, commit and then raise error. Please review the changes and decide which approach you want to take.

Fixes #1814

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik Lancetnik added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit d60f3bc Oct 8, 2024
27 checks passed
@Lancetnik Lancetnik deleted the autocommit-precommit-changes branch October 8, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocommit pre-commit changes to PR
2 participants