Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-commit can fail with two types of errors - 1. auto fixable(linting, codespell, etc), 2. manually fixable(mypy, semgrep, etc).
We can auto commit changes only if the failure is because of 1. auto fixable failure.
@Lancetnik I took an approach here where I run the
auto fixable
hooks alone first, commit next and then run everything again.There could be an alternative approach too. Run everything first, commit and then raise error. Please review the changes and decide which approach you want to take.
Fixes #1814
Type of change
Please delete options that are not relevant.
Checklist
scripts/lint.sh
shows no errors)scripts/test-cov.sh
scripts/static-analysis.sh