Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Prometheus Middleware #1791

Merged
merged 62 commits into from
Oct 20, 2024
Merged

Conversation

roma-frolov
Copy link
Contributor

@roma-frolov roma-frolov commented Sep 14, 2024

Description

Implemented Prometheus middleware for all brokers.

It seems to me that the getting-started documentation for prometheus middlewares (index.md) is not entirely complete. I would be glad to receive suggestions on what I would like to see in the documentation for this implementation.

Fixes #1665

Type of change

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik Lancetnik added enhancement New feature or request Core Issues related to core FastStream functionality and affects to all brokers labels Sep 16, 2024
@roma-frolov roma-frolov marked this pull request as ready for review September 19, 2024 20:02
Copy link

@vignesh1507 vignesh1507 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the changes and really appreciate the effort @roma-frolov. Thanks for contributing to this mind-blowing project.

Copy link

@vignesh1507 vignesh1507 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the effort @roma-frolov.

tests/prometheus/basic.py Outdated Show resolved Hide resolved
tests/prometheus/confluent/test_confluent.py Outdated Show resolved Hide resolved
tests/prometheus/basic.py Outdated Show resolved Hide resolved
tests/prometheus/confluent/test_confluent.py Show resolved Hide resolved
faststream/confluent/prometheus/middleware.py Outdated Show resolved Hide resolved
faststream/confluent/prometheus/middleware.py Show resolved Hide resolved
@Lancetnik Lancetnik added this pull request to the merge queue Oct 20, 2024
Merged via the queue into airtai:main with commit 975d182 Oct 20, 2024
33 checks passed
@roma-frolov roma-frolov deleted the feat/prometheus branch October 20, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issues related to core FastStream functionality and affects to all brokers enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Prometheus Middleware to collect metrics
4 participants