Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly template extraEnv values #874

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jessebye
Copy link

@jessebye jessebye commented Jul 18, 2024

What issues does your PR fix?

#879

What does your PR do?

Runs extraEnv values through tpl so users can utilize templating in their values.

Checklist

For all Pull Requests

For releasing ONLY

@jessebye jessebye changed the title Properly template extraEnv and extraEnvFrom values Properly template extraEnv values Jul 18, 2024
Copy link

@montanapayne montanapayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice++

@jessebye
Copy link
Author

@thesuperzapper Hey, sorry to bother, but would you be able to give this a look? We're currently maintaining a separate fork just for this reason.

@jessebye jessebye changed the title Properly template extraEnv values fix: properly template extraEnv values Aug 21, 2024
@thesuperzapper
Copy link
Member

@jessebye please don't cut a release in this PR, only make template changes.

Also, we might want to include a small blurb about this in our docs (which live in markdown files on this repo):

Signed-off-by: Jesse Bye <[email protected]>
Signed-off-by: jessebye <[email protected]>
@jessebye
Copy link
Author

@thesuperzapper Ok, did a quick rebase and updated the documentation to mention use of templating in extraEnv. Please let me know if there are any other changes you'd like to see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants