Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add topologySpreadConstraints values #752

Conversation

ron-damon
Copy link
Contributor

@ron-damon ron-damon commented Jun 21, 2023

What issues does your PR fix?

What does your PR do?

This PR adds the following values:

  • airflow.defaultTopologySpreadConstraints (default: [])
  • airflow.kubernetesPodTemplate.topologySpreadConstraints (default: [])
  • airflow.dbMigrations.topologySpreadConstraints (default: [])
  • airflow.sync.topologySpreadConstraints (default: [])
  • scheduler.topologySpreadConstraints (default: [])
  • web.topologySpreadConstraints (default: [])
  • workers.topologySpreadConstraints (default: [])
  • triggerer.topologySpreadConstraints (default: [])
  • flower.topologySpreadConstraints (default: [])
  • pgbouncer.topologySpreadConstraints (default: [])

Checklist

For all Pull Requests

@MrBones757
Copy link

Awesome to see a PR for this - I'm looking for this myself and was going to submit a PR for it if there wasn't already one
What is the status of this PR? is there an eta on seeing this released / is there any additional testing / work required on this feature?

Happy to help where needed.
Thanks in advance!

@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had activity in 60 days.
It will be closed in 7 days if no further activity occurs.

Thank you for your contributions.


Issues never become stale if any of the following is true:

  1. they are added to a Project
  2. they are added to a Milestone
  3. they have the lifecycle/frozen label

@stale stale bot added the lifecycle/stale lifecycle - this is stale label Sep 17, 2023
@ron-damon ron-damon force-pushed the feat/add-topology-spread-constraints branch from 89fbc5b to fc73d07 Compare September 22, 2023 14:50
@ron-damon
Copy link
Contributor Author

/remove-lifecycle stale

@stale stale bot removed the lifecycle/stale lifecycle - this is stale label Sep 22, 2023
@saschajullmann
Copy link

Hey all,

is there any timeline here/ is there anything you need help with in order to allow this to get merged @thesuperzapper ?

@jbvaningen
Copy link
Contributor

We would also love to have this PR merged! This is currently one of the main blockers for us to avoid monkey-patching the chart in our Airflow setup

Copy link

stale bot commented Mar 13, 2024

This issue has been automatically marked as stale because it has not had activity in 60 days.
It will be closed in 7 days if no further activity occurs.

Thank you for your contributions.


Issues never become stale if any of the following is true:

  1. they are added to a Project
  2. they are added to a Milestone
  3. they have the lifecycle/frozen label

@stale stale bot added the lifecycle/stale lifecycle - this is stale label Mar 13, 2024
@ron-damon
Copy link
Contributor Author

/remove-lifecycle stale

@stale stale bot removed the lifecycle/stale lifecycle - this is stale label Mar 14, 2024
@thesuperzapper thesuperzapper added this to the airflow-8.9.0 milestone May 1, 2024
Signed-off-by: ron-damon <[email protected]>
Signed-off-by: ron-damon <[email protected]>
@thesuperzapper thesuperzapper force-pushed the feat/add-topology-spread-constraints branch from fc73d07 to c39c1a5 Compare May 1, 2024 01:17
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
Copy link
Member

@thesuperzapper thesuperzapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ron-damon thanks for your great work on this!

I pushed a small cleanup to re-order the values and update the docs pages.

It will be in the next release of the chart.

@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into next release label May 1, 2024
@thesuperzapper thesuperzapper merged commit a8d97bf into airflow-helm:main May 1, 2024
3 checks passed
@ron-damon ron-damon deleted the feat/add-topology-spread-constraints branch May 2, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready-to-merge status - this will be merged into next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for topologySpreadConstraints to Helm Chart
5 participants