Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix width incorrectly passed to showkaseHeightDp param in ShowkaseMetadata. #336

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

julioromano
Copy link
Contributor

Most likely a typo I suppose.

…seMetadata`.

Most likely a typo I suppose.
@@ -353,7 +353,7 @@ internal fun getShowkaseMetadataFromCustomAnnotation(
showkaseName = showkaseName,
showkaseGroup = showkaseGroup,
showkaseWidthDp = if (width == -1) null else width,
showkaseHeightDp = if (height == -1) null else width,
showkaseHeightDp = if (height == -1) null else height,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 Thank you for fixing it, typo indeed!

@vinaygaba vinaygaba merged commit 9f49a32 into airbnb:master Aug 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants