Skip to content

Commit

Permalink
Change cibuildwheel test-requires lockfile to pytest.txt (#827)
Browse files Browse the repository at this point in the history
* Fix cibuildwheel test-requires

requirements-ci includes `-e .` which rebuilts multidict and installs
this version. As a result cibuildwheel ends up not testing the wheel
it built, instead testing a separate wheel built by `pip install -e .`

cibuildwheel automatically installs the multidict wheel, so we should
only install test-requires not multidict itself.

* Add a change note for PR #827

* Add "lockfile" to known words

---------

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
  • Loading branch information
hoodmane and webknjaz authored Dec 27, 2023
1 parent cc556df commit 84286ac
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGES/827.contrib.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Updated the test pins lockfile used in the
``cibuildwheel`` test stage -- by :user:`hoodmane`.
1 change: 1 addition & 0 deletions docs/spelling_wordlist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ json
keepalive
keepalives
keepaliving
lockfile
lookups
manylinux
middleware
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ requires = ["setuptools >= 40"]


[tool.cibuildwheel]
test-requires = "-r requirements/ci.txt"
test-requires = "-r requirements/pytest.txt"
test-command = "pytest {project}/tests"
# don't build PyPy wheels, install from source instead
skip = "pp*"

0 comments on commit 84286ac

Please sign in to comment.