Allow a memory specification of zero for the SLURM plugin #6605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6605 +/- ##
==========================================
+ Coverage 77.51% 77.88% +0.38%
==========================================
Files 560 567 +7
Lines 41444 42120 +676
==========================================
+ Hits 32120 32802 +682
+ Misses 9324 9318 -6 ☔ View full report in Codecov by Sentry. |
In SLURM memory specification, a value of zero is treated as a special case indicating that no memory limit should be used. This is documented here: https://slurm.schedmd.com/sbatch.html under the '--mem' section. Currently the SLURM plugin demands a positive integer, but this logic puts an unexpected limitation on the SLURM plugin. This commit changes this logic to allow a value of 0 to be acctepted.
ConradJohnston
force-pushed
the
Allow_zero_memory_in_slurm
branch
from
2784b2b
to
47f83b9
Compare
|
I think @giovannipizzi wrote the SLURM plugin, in time immemorial. |
giovannipizzi
changed the title
giovannipizzi
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SLURM memory specification, a value of zero is treated as a special case indicating that no memory limit should be used. This is documented here under the '--mem' section.
Currently the SLURM plugin demands a positive integer, but this logic puts an unexpected limitation on the SLURM plugin. This commit changes this logic to allow a value of 0 to be acctepted.