Fix DBA to work with Julia 1.x #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maetshju
commented
Mar 8, 2020
| arr[:,i] = seq[i][:] | ||
| end | ||
| return arr | ||
| function seq_to_array(seq::Sequence{N}) where N |
There was a problem hiding this comment.
I had updated this function to work as part of the debugging/dev process. It's not central to the operation of the dba() function now, but I think using the cat() function is clearer in terms of exposing how the array is constructed from the Sequence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a handful of changes to get DBA to work with newer versions of Julia. It also adds a simple DBA test to the test suite so that CI or otherwise can catch code regressions or syntax etc. incompatibilities with DBA.