Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #988, run inverse search command as separated command and args #989

Merged
merged 2 commits into from
Feb 28, 2024
Merged

fix #988, run inverse search command as separated command and args #989

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a0d359
fix #988, run inverse search command as separated command and args
jinjiaodawang Feb 28, 2024
56d0e9f
Restore OS conditions for inverse search
jinjiaodawang Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pdf_viewer/main_widget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// deduplicate database code
// deduplicate database code
// make sure jsons exported by previous sioyek versions can be imported
// maybe: use a better method to handle deletion of canceled download portals
// change find_closest_*_index and argminf to use the fact that the list is sorted and speed up the search (not important if there are not a ridiculous amount of highlight/bookmarks)
Expand Down Expand Up @@ -4766,8 +4766,8 @@ std::wstring MainWidget::synctex_under_pos(WindowPos position) {
#else
QString command = QString::fromStdWString(inverse_search_command).arg(file_name, line_string.c_str(), column_string.c_str());
#endif
res = QString("%1 %2 %3").arg(new_path, QString::number(line), QString::number(column)).toStdWString();
QProcess::startDetached(command);
QStringList args = QProcess::splitCommand(command);
QProcess::startDetached(args[0], args.mid(1));
}
else {
show_error_message(L"inverse_search_command is not set in prefs_user.config");
Expand Down
Loading