workaround for bug #565

[NightMachinery]

This PR solves the two issues in [BUG] Bigger font sizes make menu text go off screen · Issue #565 · ahrm/sioyek.

1. The scrollbar hiding the shortcuts.
2. The height of the menu rows not adjusting to big font sizes:

---

The final result looks like this:

[ahrm]

Thanks :). I need to test these PRs on multiple operating systems before accepting them so it might take a while because currently I am a little busy.

[NightMachinery]

Thanks, take your time. I do have more PRs lined up. :D
Something I noticed when editing the code; there is a pdf_viewer/pdf_view_opengl_widget.{cpp,h}. Is that file still used somewhere? Or is it just legacy stuff? There is a lot of code repeated between that file and main_widget.{h,cpp}, I think.

[ahrm]

Yes, it is absolutely used, it is the main view of the application. I don't think a lot of code is duplicated between those (can you provide an example). Maybe the thing you are referring is that there are many functions with similar names. But these functions in main_widget usually just simply call the corresponding functions in pdf_view_opengl_widget.

[NightMachinery]

Yes, it is absolutely used, it is the main view of the application. I don't think a lot of code is duplicated between those (can you provide an example). Maybe the thing you are referring is that there are many functions with similar names. But these functions in main_widget usually just simply call the corresponding functions in pdf_view_opengl_widget.

For example, PdfViewOpenGLWidget::wheelEvent and MainWidget::wheelEvent. I have been editing MainWidget::wheelEvent to make it use a separate zoom inc factor, and so that shift+scrolling for horizontal scrolling works even when the horizontal lock is active. And my modifications work. I haven't touched the code in PdfViewOpenGLWidget::wheelEvent though, which made me think the code there never runs.

[ahrm]

The wheelEvent in pdf_view_opengl_widget handles the helper window case (the window that displays the portals, because it does not have a MainWidget to handle the wheelEvent). I agree that this may be not the cleanest way to implement this but the different wheelEvents both do serve a purpose.

[NightMachinery]

Closing this as it's useless on dev (QT 6).