Fix the issue where next_chapter moved two chapters if executed inside a

chapter (addresses #987)
ahrm · Feb 27, 2024 · 5b0cd55 · 5b0cd55
1 parent dbe3b39
commit 5b0cd55
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/pdf_viewer/document_view.cpp b/pdf_viewer/document_view.cpp
@@ -1060,6 +1060,10 @@ void DocumentView::goto_chapter(int diff) {
         index++;
     }
 
+    if (index < chapter_pages.size() && chapter_pages[index] > curr_page) {
+        index--;
+    }
+
     int new_index = index + diff;
     if (new_index < 0) {
         goto_page(0);

diff --git a/pdf_viewer/input.cpp b/pdf_viewer/input.cpp
@@ -3941,6 +3941,10 @@ class NextChapterCommand : public Command {
         widget->main_document_view->goto_chapter(rp);
     }
 
+    bool pushes_state() {
+        return true;
+    }
+
 };
 
 class PrevChapterCommand : public Command {
@@ -3954,6 +3958,10 @@ class PrevChapterCommand : public Command {
         widget->main_document_view->goto_chapter(-rp);
     }
 
+    bool pushes_state() {
+        return true;
+    }
+
 };
 
 class ShowContextMenuCommand : public Command {