keep status state only for main branch in allowed pipelines

ahrefs · Jan 31, 2025 · cd26b3e · cd26b3e
1 parent 75ae179
commit cd26b3e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/action.ml b/lib/action.ml
@@ -252,7 +252,7 @@ module Action (Github_api : Api.Github) (Slack_api : Api.Slack) (Buildkite_api :
     in
     let%lwt recipients =
       let rules = cfg.status_rules.rules in
-      match Context.is_pipeline_allowed ctx repo.url n with
+      match Context.is_pipeline_allowed ctx n with
       | false -> Lwt.return []
       | true ->
         let%lwt dm_and_channels =
@@ -287,7 +287,9 @@ module Action (Github_api : Api.Github) (Slack_api : Api.Slack) (Buildkite_api :
         let%lwt failed_builds_channel = get_failed_builds_channel_id () in
         Lwt.return (dm_and_channels @ failed_builds_channel |> List.sort_uniq Status_notification.compare)
     in
-    State.set_repo_pipeline_status ctx.state n;
+    (* We only care about maintaining status for allowed pipelines and the main branch *)
+    if Util.Build.is_main_branch cfg n && Context.is_pipeline_allowed ctx n then
+      State.set_repo_pipeline_status ctx.state n;
     Lwt.return recipients
 
   let partition_commit_comment (ctx : Context.t) n =

diff --git a/lib/context.ml b/lib/context.ml
@@ -76,8 +76,8 @@ let hook_of_channel ctx channel_name =
 (** [is_pipeline_allowed ctx repo_url notification] returns [true] if [status_rules]
     doesn't define a whitelist of allowed pipelines in the config of [repo_url],
     or if the list contains the pipeline name in [notification.context]; returns [false] otherwise. *)
-let is_pipeline_allowed ctx repo_url (n : Github_t.status_notification) =
-  match find_repo_config ctx repo_url with
+let is_pipeline_allowed ctx (n : Github_t.status_notification) =
+  match find_repo_config ctx n.repository.url with
   | None -> true
   | Some config -> Option.is_some (Util.Build.get_pipeline_config config n)