Updates to bindings for XYZ axes, Treemap, Pie, and Cell components #59
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,49 +8,155 @@ external make: | |
| ~allowDataOverflow: bool=?, | ||
| ~allowDecimals: bool=?, | ||
| ~allowDuplicatedCategory: bool=?, | ||
| ~axisLine: | ||
| [@mel.unwrap] [ | ||
| | `Bool(bool) | ||
| | `Obj(Js.t({..})) | ||
| ] | ||
| =?, | ||
| ~className: string=?, | ||
| ~dataKey: | ||
| [@mel.unwrap] [ | ||
| | `Str(string) | ||
| | `Int(int) | ||
| | `Fn('dataObj => 'data) | ||
| ] | ||
| =?, | ||
| ~domain: array('domain)=?, | ||
| ~height: int=?, | ||
| ~hide: bool=?, | ||
| ~interval: AxisInterval.t=?, | ||
| ~label: | ||
| [@mel.unwrap] [ | ||
|
There was a problem hiding this comment. Should we maybe replace some of those types in https://github.com/ahrefs/melange-recharts/blob/master/src/Utils.re#L135 There was a problem hiding this comment. I'd like to tackle this in another PR but I think this is a great suggestion. |
||
| | `Str(string) | ||
| | `Int(int) | ||
| | `Float(float) | ||
| | `Component(React.element) | ||
| | `Obj(Js.t({..})) | ||
| ] | ||
| =?, | ||
| ~minTickGap: int=?, | ||
| ~mirror: bool=?, | ||
| ~name: | ||
| [@mel.unwrap] [ | ||
| | `Str(string) | ||
| | `Int(int) | ||
| | `Float(float) | ||
| ] | ||
| =?, | ||
| ~onClick: (. Js.Nullable.t(Js.t({..})), React.Event.Mouse.t) => unit=?, | ||
| ~onMouseDown: | ||
| (. Js.Nullable.t(Js.t({..})), React.Event.Mouse.t) => unit=?, | ||
| ~onMouseEnter: | ||
| (. Js.Nullable.t(Js.t({..})), React.Event.Mouse.t) => unit=?, | ||
| ~onMouseLeave: (. Js.t({..}), React.Event.Mouse.t) => unit=?, | ||
| ~onMouseMove: | ||
| (. Js.Nullable.t(Js.t({..})), React.Event.Mouse.t) => unit=?, | ||
| ~onMouseOut: | ||
| (. Js.Nullable.t(Js.t({..})), React.Event.Mouse.t) => unit=?, | ||
| ~onMouseOver: | ||
| (. Js.Nullable.t(Js.t({..})), React.Event.Mouse.t) => unit=?, | ||
| ~onMouseUp: (. Js.Nullable.t(Js.t({..})), React.Event.Mouse.t) => unit=?, | ||
| ~orientation: | ||
| [ | ||
| | `bottom | ||
| | `top | ||
| ] | ||
| =?, | ||
| ~padding: paddingHorizontal=?, | ||
| ~range: array(int)=?, | ||
| ~reversed: bool=?, | ||
| ~scale: scale=?, | ||
| ~stroke: string=?, | ||
| ~style: ReactDOM.Style.t=?, | ||
| ~tick: | ||
| [@mel.unwrap] [ | ||
| | `Obj(Js.t({..})) | ||
| | `Component(React.element) | ||
| | `Bool(bool) | ||
| | `Fn('tick => React.element) | ||
| ] | ||
| =?, | ||
| ~tickCount: int=?, | ||
| ~tickFormatter: (. 'tick, int) => string=?, | ||
| ~tickLine: | ||
| [@mel.unwrap] [ | ||
| | `Bool(bool) | ||
| | `Obj(Js.t({..})) | ||
| ] | ||
| =?, | ||
| ~tickMargin: int=?, | ||
| ~ticks: array('ticks)=?, | ||
| ~tickSize: | ||
| [@mel.unwrap] [ | ||
| | `Float(float) | ||
| | `Int(int) | ||
| ] | ||
| =?, | ||
| ~transform: string=?, | ||
| ~unit: string=?, | ||
| ~width: int=?, | ||
| ~xAxisId: string=? | ||
| ) => | ||
| React.element = | ||
| "XAxis"; | ||
|
|
||
| let makeProps = | ||
| ( | ||
| ~interval=?, | ||
| ~onClick=?, | ||
| ~onMouseDown=?, | ||
| ~onMouseEnter=?, | ||
| ~onMouseLeave=?, | ||
| ~onMouseMove=?, | ||
| ~onMouseOut=?, | ||
| ~onMouseOver=?, | ||
| ~onMouseUp=?, | ||
| ~tickFormatter=?, | ||
| ) => | ||
| makeProps( | ||
| ~interval=?interval |> AxisInterval.encodeOpt, | ||
| ~onClick=? | ||
| onClick | ||
| |> Option.map(onClick => (. payload, event) => onClick(payload, event)), | ||
| ~onMouseDown=? | ||
| onMouseDown | ||
| |> Option.map(onMouseDown => | ||
| (. payload, event) => onMouseDown(payload, event) | ||
| ), | ||
| ~onMouseEnter=? | ||
| onMouseEnter | ||
| |> Option.map(onMouseEnter => | ||
| (. payload, event) => onMouseEnter(payload, event) | ||
| ), | ||
| ~onMouseLeave=? | ||
| onMouseLeave | ||
| |> Option.map(onMouseLeave => | ||
| (. payload, event) => onMouseLeave(payload, event) | ||
| ), | ||
| ~onMouseMove=? | ||
| onMouseMove | ||
| |> Option.map(onMouseMove => | ||
| (. payload, event) => onMouseMove(payload, event) | ||
| ), | ||
| ~onMouseOut=? | ||
| onMouseOut | ||
| |> Option.map(onMouseOut => | ||
| (. payload, event) => onMouseOut(payload, event) | ||
| ), | ||
| ~onMouseOver=? | ||
| onMouseOver | ||
| |> Option.map(onMouseOver => | ||
| (. payload, event) => onMouseOver(payload, event) | ||
| ), | ||
| ~onMouseUp=? | ||
| onMouseUp | ||
| |> Option.map(onMouseUp => | ||
| (. payload, event) => onMouseUp(payload, event) | ||
| ), | ||
| ~tickFormatter=? | ||
| tickFormatter | ||
| |> Option.map(tickFormatter => | ||
| (. tick, index) => tickFormatter(tick, index) | ||
| ), | ||
| ); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can add something along the lines of the PR description in one line ("Improve bindings for XYZ axes, Treemap, Pie and Cell components"), with a link to the PR for those interested on details.
I would also add "Breaking" before it.
example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done