Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel: add option to not revive upon clear termination #30

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

vasilisp
Copy link

@vasilisp vasilisp commented Aug 15, 2024

The PR enriches the semantics of Parallel.run_forks ~revive with an option to only revive workers with non-zero exit status. Setting ~revive:Always preserves the original behavior of ~revive:true.

Success is naturally determined by the Unix exit status, so child processes now return 1 if they exit with an exception.

This is joint work with @yasunariw .

@rr0gi rr0gi self-requested a review August 15, 2024 16:22
@rr0gi
Copy link
Contributor

rr0gi commented Oct 22, 2024

please make revive a variant Always | Never | `On_failure

@yasunariw yasunariw changed the title parallel: do not revive upon clear termination parallel: add option to not revive upon clear termination Oct 22, 2024
@yasunariw
Copy link
Contributor

updated PR description

@yasunariw yasunariw merged commit dc07cd9 into master Oct 25, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants