Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving #283 user warning when delay_after_gen is not in use #297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

greenLeopard
Copy link

@greenLeopard greenLeopard commented Jul 17, 2024

I've made three small changes to remove the UserWarning without suppressing all warnings (#283 ).

  1. In the constructor, set the default value for delay_after_gen to None.
  2. In the validation step, if the incoming argument is None, set self.delay_after_gen to None.
  3. Before calling time.sleep(self.delay_after_gen) just check whether it's None.

Although, the alternative, since it's being deprecated, is to remove all references to delay_after_gen. I'll be happy to do that if it's your preference, then I'll resubmit the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant