Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌲 Dbot updates, handful of fixes, etc #117

Merged
merged 5 commits into from
Oct 8, 2024
Merged

🌲 Dbot updates, handful of fixes, etc #117

merged 5 commits into from
Oct 8, 2024

Conversation

jacobdadams
Copy link
Member

  • Update arcgis to 2.4
  • fix spatial reference issue in sedf -> gdf
  • fix log message
  • remove date parsing from postgres loader

dependabot bot and others added 4 commits October 7, 2024 16:21
Updates the requirements on [arcgis](https://developers.arcgis.com/python/) to permit the latest version.

Updates `arcgis` to 2.4.0

---
updated-dependencies:
- dependency-name: arcgis
  dependency-type: direct:production
  dependency-group: major-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
This should be done via `transform.DataCleaning.switch_to_datetime` now and doing it via the loader was causing issues.
Copy link
Member

@steveoh steveoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the unit tests are failing? Otherwise it looks good.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.88%. Comparing base (f87f4c5) to head (05bd82e).
Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
src/palletjack/extract.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   94.52%   94.88%   +0.35%     
==========================================
  Files           7        7              
  Lines        1133     1154      +21     
  Branches      148      176      +28     
==========================================
+ Hits         1071     1095      +24     
+ Misses         52       51       -1     
+ Partials       10        8       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobdadams jacobdadams merged commit 5c7dbb2 into main Oct 8, 2024
4 of 5 checks passed
@jacobdadams jacobdadams deleted the dev branch October 8, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants