Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance cloud check in PostgresLoader to work in any GCP environment #111

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

stdavis
Copy link
Member

@stdavis stdavis commented Oct 4, 2024

Prior to this change, it only worked in functions.

I didn't have a great way to test this but I'm fairly certain that it's good. I did test the False path and it worked.

…nment

Prior to this change, it only worked in functions.
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.64%. Comparing base (f87f4c5) to head (5f5f384).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
src/palletjack/extract.py 0.00% 0 Missing and 1 partial ⚠️
src/palletjack/utils.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   94.52%   94.64%   +0.11%     
==========================================
  Files           7        7              
  Lines        1133     1157      +24     
  Branches      148      177      +29     
==========================================
+ Hits         1071     1095      +24     
- Misses         52       53       +1     
+ Partials       10        9       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobdadams
Copy link
Member

Looks good to me. Thanks for the update.

@jacobdadams jacobdadams merged commit 05748f2 into main Oct 4, 2024
3 of 4 checks passed
@jacobdadams jacobdadams deleted the fix/cloud-check branch October 4, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants