Performance improvements #44
Conversation
This saves multiple fork/execs (for the subshell and wc) each time the prompt is rendered
Rather than forking a subshell to print the prompt, construct it incrementally by appending to $PROMPT. To enable this, expand the unicode escapes ahead of time.
|
While this may improve performance, I don't think this will drastically reduce the number of forks. There's also a large chance this adds back the exploit (https://github.com/njhartwell/pw3nage) which was fixed in #33. The jobstates fix does seem like it might help though. |
|
@belak Hmm, I think you're right about the exploit being re-introduced; I hadn't noticed that when I did this work. But what about the other change (897b31f) to use |
|
Unfortunately I don't have merge access to this repo... I'm just fairly familiar with the code. The first commit looks fine to me though. :) |
| @@ -117,7 +119,7 @@ prompt_status() { | |||
| symbols=() | |||
| [[ $RETVAL -ne 0 ]] && symbols+="%{%F{red}%}$CROSS" | |||
| [[ $UID -eq 0 ]] && symbols+="%{%F{yellow}%}$LIGHTNING" | |||
| [[ $(jobs -l | wc -l) -gt 0 ]] && symbols+="%{%F{cyan}%}$GEAR" | |||
| [[ ${#jobstates} -ne 0 ]] && symbols+="%{%F{cyan}%}$GEAR" | |||
There was a problem hiding this comment.
Note: this conflicts with the nohup filtering proposed in #61.
This PR improves performance, especially when we're not in a git repo, by cutting down the number of forks/execs needed just to render the prompt. It's a particularly noticeable speedup on Cygwin.