Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved git-info right after user@host and moved cursor on a new line #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

andreidmt
Copy link

Why did you do it?

  1. Moving git-info makes sense because it's a better visual anchor, it's after a fixed width section (user@host) and you don't have to adjust when you change your git project.
  2. Putting cursor on a new line also because it's a better anchor (always at the beginning of the line) and because I often find myself not having enough space to see the command properly because the path was to big and the command jumped on 2 lines.

What exactly did you do?
Changed the order in prompt_agnoster_main and added a new prompt_cursor function.

Why did you do it?
1. Moving git-info makes sense because it's a better visual anchor, it's after
a fixed width section (user@host) and you don't have to adjust when you change
your git project.

2. Putting cursor on a new line also because it's a better anchor (always at the beginning of the line) and because I often find myself not having enough
space to see the command properly because the path was to big and the
command jumped on 2 lines.

What exactly did you do?
Changed the order in `prompt_agnoster_main` and added a new `prompt_cursor`
function.
@TimBeyer
Copy link

I really like the option of having the cursor on a new line.
Else there is just not enough space.

👍

@apjanke
Copy link
Collaborator

apjanke commented Jan 3, 2020

This is a big aesthetic change. Maybe there should be a $AGN_MULTILINE variable to control whether it's enabled?

@apjanke
Copy link
Collaborator

apjanke commented Jan 3, 2020

FYI, I did this over in my AgnosterJ fork: apjanke/agnosterj-zsh-theme@51cc2da

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants