Update Select.tsx #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DakotahGodfrey
approved these changes
Nov 8, 2024
|
Sorry can you also increment the version number in the package.json I'll publish the latest version once this has been merged. |
DakotahGodfrey
previously approved these changes
Nov 8, 2024
…ender-the-DISPLAY-text-from-the-dropdown-not-the-value
DakotahGodfrey
approved these changes
Nov 8, 2024
DakotahGodfrey
deleted the
FE-1521-Content-List-Dropdown-field-should-render-the-DISPLAY-text-from-the-dropdown-not-the-value
branch
| @@ -95,7 +95,7 @@ const Select: React.FC<ISelectProps> = ({ | |||
| > | |||
| {options.map(({ value, label }) => { | |||
| return ( | |||
| <option key={value} value={value}> | |||
| <option key={value} value={label}> | |||
There was a problem hiding this comment.
@AaronAgility We have to revert this change that you made in this PR as it was causing all selects in the manager app to now work properly. Was there a reason for this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the option value to label for select component