Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[91] - Adding CT loading functionality to web interface #161

Merged
merged 20 commits into from
Oct 16, 2023

Conversation

NewtonSander
Copy link
Collaborator

@NewtonSander NewtonSander commented Oct 2, 2023

Introduction

#91 - Adding the possibility of loading a custom CT scan to the web interface

Behavior

The user has to upload two files, one will be the .nii or .zip with the dicom files, the other will be a .json containing the mapping between the material layer names and the layer number, like this:

{  
    "water": 0,
    "brain": 1,
    "trabecular_bone": 2
}

After performing the upload, the CT scan is available on the CT Scan section of the web interface

Usage

Download and extract ct-scans.zip
Start the web server, click the CT Scan toggle and select a pair of two files with the same name from the extracted folder to make the upload.

@NewtonSander NewtonSander changed the base branch from main to implementing_web_ui October 2, 2023 12:01
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
.../neurotechdevkit/scenarios/built_in/_scenario_2.py 98.88% <ø> (ø)
src/neurotechdevkit/grid.py 92.59% <77.77%> (-0.27%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@NewtonSander NewtonSander marked this pull request as ready for review October 2, 2023 19:07
Copy link
Contributor

@charlesbmi charlesbmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this. I couldn't quite get it to run locally - perhaps I wasn't extracting ct-scans.zip to the right location? Happy to show my setup over video-call some time if that would be helpful.

Also, are you going to merge implementing_web_ui first and then redirect this branch to main?

That implementing_web_ui PR looked almost done - feel free to let me know when it is ready for another review :)

src/web/views.py Show resolved Hide resolved
@NewtonSander NewtonSander merged commit b58d1c9 into implementing_web_ui Oct 16, 2023
13 checks passed
@NewtonSander NewtonSander deleted the ct-loading-to-web branch October 16, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants