Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing new API for NDK #122

Merged
merged 46 commits into from
Aug 9, 2023
Merged

Implementing new API for NDK #122

merged 46 commits into from
Aug 9, 2023

Commits on Jul 31, 2023

  1. Implementing new API for NDK

    @NewtonSander
    NewtonSander committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    d34df26 View commit details
    Browse the repository at this point in the history

  2. Updating gallery examples to use the new API

    @NewtonSander
    NewtonSander committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    f4a6e31 View commit details
    Browse the repository at this point in the history

  3. Updating 3d scenario result

    @NewtonSander
    NewtonSander committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    e6bfc34 View commit details
    Browse the repository at this point in the history

  4. Cleaning up scenario __init__

    @NewtonSander
    NewtonSander committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    947d919 View commit details
    Browse the repository at this point in the history

  5. Updating api docs

    @NewtonSander
    NewtonSander committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    675141e View commit details
    Browse the repository at this point in the history

  6. Compiling problem explicitly

    @NewtonSander
    NewtonSander committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    6e09974 View commit details
    Browse the repository at this point in the history

  7. Small fixes to plot full scenario

    @NewtonSander
    NewtonSander committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    de893ab View commit details
    Browse the repository at this point in the history

  8. Creating NDK's own Problem class

    @NewtonSander
    NewtonSander committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    008736f View commit details
    Browse the repository at this point in the history

  9. Removing 'scenario_id' attribute

    @NewtonSander
    NewtonSander committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    0f80407 View commit details
    Browse the repository at this point in the history

  10. Cleaning up

    @NewtonSander
    NewtonSander committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    72d7198 View commit details
    Browse the repository at this point in the history

  11. Fixing docs

    @NewtonSander
    NewtonSander committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    4d5b39e View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Decoupling render layout from compile problem

    @NewtonSander
    NewtonSander committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    234333f View commit details
    Browse the repository at this point in the history

  2. Moving grid creation to its own class

    @NewtonSander
    NewtonSander committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    6a1381e View commit details
    Browse the repository at this point in the history

  3. Moving center_frequency to the scenario root

    @NewtonSander
    NewtonSander committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    ed9bee5 View commit details
    Browse the repository at this point in the history

  4. Cleaning up

    @NewtonSander
    NewtonSander committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    ea05ccb View commit details
    Browse the repository at this point in the history

  5. Cleaning up code. Invalidating grid and compiled problem when center_… 

    …frequency is changed
    @NewtonSander
    NewtonSander committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    4b1f809 View commit details
    Browse the repository at this point in the history

  6. Adapting documentation

    @NewtonSander
    NewtonSander committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    fa70d93 View commit details
    Browse the repository at this point in the history

  7. Updating plot full scenario to use the procedural approach

    @NewtonSander
    NewtonSander committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    7cda863 View commit details
    Browse the repository at this point in the history

  8. Updating API docs adding the Grid and Problem pages

    @NewtonSander
    NewtonSander committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    944473a View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Fixing bug with 3D example

    @NewtonSander
    NewtonSander committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    6ebfcfe View commit details
    Browse the repository at this point in the history

  2. Improving docs, updating hash of 3d results file

    @NewtonSander
    NewtonSander committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    0f29fdf View commit details
    Browse the repository at this point in the history

  3. Improving docs

    @NewtonSander
    NewtonSander committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    a1df0d9 View commit details
    Browse the repository at this point in the history

  4. Small improvements to notebook

    @NewtonSander
    NewtonSander committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    95d9ed2 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Addressing review suggestion: replacing enum with subdirectory contai… 

    …ning the built in scenarios
    @NewtonSander
    NewtonSander committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    e9000ad View commit details
    Browse the repository at this point in the history

  2. Update src/neurotechdevkit/grid.py 

    Co-authored-by: charles <[email protected]>
    @NewtonSander @charlesbmi
    NewtonSander and charlesbmi authored Aug 4, 2023
    Configuration menu
    Copy the full SHA
    8a0fb1f View commit details
    Browse the repository at this point in the history

  3. Addressing review suggestion

    @NewtonSander
    NewtonSander committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    d7f7310 View commit details
    Browse the repository at this point in the history

  4. Fixing issue with commited PR suggestion

    @NewtonSander
    NewtonSander committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    e14500b View commit details
    Browse the repository at this point in the history

  5. Fixing bug

    @NewtonSander
    NewtonSander committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    a9e4f94 View commit details
    Browse the repository at this point in the history

  6. Removing layer_ids from problem creation. Removing need of creating m… 

    …aterial_layers, using material_masks keys instead
    @NewtonSander
    NewtonSander committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    1b64340 View commit details
    Browse the repository at this point in the history

  7. Fixing print

    @NewtonSander
    NewtonSander committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    8e9b9fc View commit details
    Browse the repository at this point in the history

  8. Replacing numpy arrays with plain lists for simple attributes like po… 

    …sition, origin and direction
    @NewtonSander
    NewtonSander committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    7b0e1a0 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Refactoring

    @NewtonSander
    NewtonSander committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    6849bf4 View commit details
    Browse the repository at this point in the history

  2. Refactoring

    @NewtonSander
    NewtonSander committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    1ed1f7e View commit details
    Browse the repository at this point in the history

  3. Fixing hash of results file

    @NewtonSander
    NewtonSander committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    d59ad66 View commit details
    Browse the repository at this point in the history

  4. Simplifying API

    @NewtonSander
    NewtonSander committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    4147be8 View commit details
    Browse the repository at this point in the history

  5. Setting center_frequency in built_in scenarios

    @NewtonSander
    NewtonSander committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    79ad06d View commit details
    Browse the repository at this point in the history

  6. Adding SliceAxis to spellcheck's whitelist

    @NewtonSander
    NewtonSander committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    8c49d22 View commit details
    Browse the repository at this point in the history

  7. Adding unit tests and cleaning up code

    @NewtonSander
    NewtonSander committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    fcaa74c View commit details
    Browse the repository at this point in the history

  8. Adding predefined target options

    @NewtonSander
    NewtonSander committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    2b850aa View commit details
    Browse the repository at this point in the history

  9. Fix typo

    @NewtonSander
    NewtonSander committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    c9bb9c9 View commit details
    Browse the repository at this point in the history

  10. Showing how the predefined targt options can be used

    @NewtonSander
    NewtonSander committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    22b9b30 View commit details
    Browse the repository at this point in the history

  11. Improving plot full scenario masks creation

    @NewtonSander
    NewtonSander committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    987c69e View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Addressing review suggestions

    @NewtonSander
    NewtonSander committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    c806dd1 View commit details
    Browse the repository at this point in the history

  2. Fixing spellchecking error by removing unnecessary types from docstrings

    @NewtonSander
    NewtonSander committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    6d6d002 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Updating 3d file hash

    @NewtonSander
    NewtonSander committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    a79f707 View commit details
    Browse the repository at this point in the history

  2. update docstrings

    @d-lucena
    d-lucena committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    c7283ea View commit details
    Browse the repository at this point in the history