fix: correction de URL dans le email de réinitialisation de mot de passe #1599
+89
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stakovicz
requested changes
Jan 25, 2025
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| use Behat\Behat\Context\Context; | |||
| use Behat\Behat\Hook\Scope\BeforeScenarioScope; | |||
| use Behat\Behat\Tester\Exception\PendingException; | |||
There was a problem hiding this comment.
Merci pour cette PR !
Je pense que ceci n'est pas utilisé.
| } | ||
|
|
||
| if (count($foundEmails) != 1) { | ||
| throw new \Exception( |
There was a problem hiding this comment.
Peut-être throw une exception du type ExpectationException ?
Il y a un exemple ici :
web/tests/behat/bootstrap/FeatureContext.php
Lines 161 to 168 in 07b4702
| ]; | ||
| } | ||
|
|
||
| if (count($foundEmails) != 1) { |
There was a problem hiding this comment.
Suggested change
| if (count($foundEmails) != 1) { | |
| if (count($foundEmails) !== 1) { |
| /** | ||
| * @When I request a password reset for :arg1 | ||
| */ | ||
| public function iRequestAPasswordReset($arg1) |
There was a problem hiding this comment.
Peut être typehinter les paramètres et retours de fonctions ?
upskaling
force-pushed
the
resolve_1563
branch
from
fe6e106 to
788b379
Compare
stakovicz
approved these changes
Jan 25, 2025
|
merci beaucoup pour le retour @stakovicz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1563