feat: Filter transactions table by date #993
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmichek
changed the title
janmichek
force-pushed
the
Filter-transactions-table-by-date
branch
from
2cfef85 to
2dfaa39
Compare
janmichek
commented
Jan 1, 2025
| @@ -28,4 +28,61 @@ describe('transactions', () => { | |||
| }) | |||
| }) | |||
| }) | |||
|
|
|||
There was a problem hiding this comment.
This was really hard to achive, hence is fully tested
janmichek
commented
Jan 1, 2025
| @@ -8,16 +8,16 @@ | |||
| </template> | |||
| <template #end> | |||
| <chart-controls | |||
| v-model="selectedRange" | |||
| v-model="selectedScope" | |||
There was a problem hiding this comment.
renaming of sibling component needed to be refactored
janmichek
commented
Jan 1, 2025
| pageLimit.value = value | ||
| } | ||
|
|
||
| function formatSlug(scope, type) { |
There was a problem hiding this comment.
there is a lot of formatting function. After several attempts this is the minimal version
|
@michele-franchi In the meantime while waiting for minor MDW fix you can do the review. I will leave it On Hold column for automation purposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #615
Demo
Checklist: