feat: add hyperchain sync support #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaboiishere
force-pushed
the
fix-hyperchain-sync
branch
from
1951016 to
15807cd
Compare
vatanasov
force-pushed
the
fix-hyperchain-sync
branch
from
412f376 to
aad3a62
Compare
yaboiishere
changed the base branch from
after-rebase-hyperchain-support
to
master
sborrazas
reviewed
Dec 15, 2024
lib/ae_mdw/stats.ex
Outdated
| @@ -162,7 +162,7 @@ defmodule AeMdw.Stats do | |||
|
|
|||
| Map.put(stats, :validators_count, validators_count) | |||
| else | |||
| Model.stat(payload: miners_count) = | |||
| {:ok, Model.stat(payload: miners_count)} = | |||
There was a problem hiding this comment.
Can we use fetch! here instead?
lib/ae_mdw/node.ex
Outdated
| @@ -345,6 +346,16 @@ defmodule AeMdw.Node do | |||
| |> MapSet.new() | |||
| end | |||
|
|
|||
| @spec epoch_start_height(epoch()) :: {:ok, height()} | {:error, atom()} | |||
| defmemo epoch_start_height(epoch) do | |||
There was a problem hiding this comment.
Do we want to memoize these? they will accumulate in memory as we call them
lib/ae_mdw/sync/hyperchain.ex
Outdated
|
|
||
| first | ||
| |> Stream.iterate(fn x -> x + 1 end) | ||
| |> Enum.zip(schedule) |
There was a problem hiding this comment.
Enum.with_index(schedule, first)
sborrazas
approved these changes
Dec 19, 2024
microblocks keyblock
This reverts commit f2a52cf.
yaboiishere
force-pushed
the
fix-hyperchain-sync
branch
from
aa20056 to
f4fddae
Compare
yaboiishere
added a commit
that referenced
this pull request
Jan 15, 2025
This reverts commit 74e098d.
yaboiishere
added a commit
that referenced
this pull request
Jan 15, 2025
--------- Co-authored-by: Valentin Atanasov <[email protected]>
yaboiishere
added a commit
that referenced
this pull request
Jan 15, 2025
--------- Co-authored-by: Valentin Atanasov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat: add hyperchain sync support
END_COMMIT_OVERRIDE
The hyperchains implementation in the node reverses the way key and microblocks are ordered. This is only done for hyperchains.
The current way is that there is a keyblock followed by all of it's microblocks until a new keyblock is produced, where after it are it's microblocks. The breaking change here is that in hc the microblocks come first followed by the keyblock they belong to. This resulted in the mdw creating sync mutations for key blocks at height N with the microblocks inside them for the next keyblock N+1.