Allow a single retry with wrong msg_type #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getters may fail as the VehicleService sends messages periodically, and the expected message with the value may not be the first one to be received. To fix it, allow one retry. One should be enough in most cases. The downside of this is that the unexpected message is discarded. Therefore, getters shall be used with care. Alternatively, we could have getters that discharge the responsibility of processing the response to users. Signed-off-by: Albert Esteve <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getters may fail as the VehicleService sends
messages periodically, and the expected message
with the value may not be the first one to be received.
To fix it, allow one retry. One should be enough
in most cases. The downside of this is that the
unexpected message is discarded. Therefore,
getters shall be used with care.
Alternatively, we could have getters that
discharge the responsibility of processing
the response to users.