fix: TOOLS-2964 Error Response from 7.2 for Show Latencies #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error Syntax has changed to ERROR:
a-spiker
changed the title
jdogmcsteezy
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Seems like a good initial task! LGTM. Only nit would be
Fix: (TOOLS-2964) Error Response from 7.2 for Show Latencies
should be
fix: TOOLS-2964 Error Response from 7.2 for Show Latencies
of course when you officially take it over you can do whatever you want but that is the current formatting rule.
After this is merged, make sure to update the aerospike-tools package to point to the latest master of aerospike-admin. Normally the commit message for that is "update admin TOOLS-2963. This helps someone looking at the ticket to see that a change has been places at the individual tool repo and then at the meta-package level.
a-spiker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error Syntax has changed to ERROR:
Checking what can be added as test for this.