tests for the env var lookup

aerogear · May 2, 2018 · 5e15a63 · 5e15a63
1 parent 7b5f5fa
commit 5e15a63
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 1 deletion.
diff --git a/common/pom.xml b/common/pom.xml
@@ -26,6 +26,7 @@
     <artifactId>unifiedpush-common</artifactId>
     <name>UnifiedPush Common classes and utils</name>
 
+
     <dependencies>
 
        <dependency>
@@ -48,6 +49,21 @@
                 <activeByDefault>true</activeByDefault>
             </activation>
 
+            <build>
+                <plugins>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-surefire-plugin</artifactId>
+                        <version>2.19.1</version>
+                        <configuration>
+                            <environmentVariables>
+                                <TEST_ENV_VAR>Ok</TEST_ENV_VAR>
+                            </environmentVariables>
+                        </configuration>
+                    </plugin>
+                </plugins>
+            </build>
+
             <dependencies>
                 <dependency>
                     <groupId>junit</groupId>
@@ -74,6 +90,7 @@
 
 
             </dependencies>
+
         </profile>
     </profiles>
 

diff --git a/common/src/main/java/org/jboss/aerogear/unifiedpush/system/ConfigurationUtils.java b/common/src/main/java/org/jboss/aerogear/unifiedpush/system/ConfigurationUtils.java
@@ -66,7 +66,7 @@ private static Integer tryGetIntegerProperty(String key, Integer defaultValue) {
      * @param key String System Property Key
      * @return String Key as environment variable
      */
-    private static String formatEnvironmentVariable(String key) {
+    public static String formatEnvironmentVariable(String key) {
         return key.toUpperCase().replaceAll("\\.", "_");
     }
 

diff --git a/common/src/test/java/org/jboss/aerogear/unifiedpush/system/ConfigurationUtilsTest.java b/common/src/test/java/org/jboss/aerogear/unifiedpush/system/ConfigurationUtilsTest.java
@@ -61,4 +61,15 @@ public void testNonExistingTryGetIntegerPropertyWithDefaultValue() {
         assertThat(ConfigurationUtils.tryGetGlobalIntegerProperty(TEST_PROPERTY_NAME, 123)).isEqualTo(123);
     }
 
+    @Test
+    public void testEnvVarFormat() {
+        assertThat(ConfigurationUtils.formatEnvironmentVariable("custom.aerogear.apns.push.host"))
+          .isEqualTo("CUSTOM_AEROGEAR_APNS_PUSH_HOST");
+    }
+
+    @Test
+    public void testEnvVarLookup() {
+        assertThat(ConfigurationUtils.tryGetGlobalProperty("test.env.var"))
+          .isEqualTo("Ok");
+    }
 }