Added SkipFilters to SDK #86
Conversation
|
This pull request has been linked to Shortcut Story #48140: JavaScript Decision SDK ignores some fields supplied in the request. |
… elements to use that rather than a generated folder.
| - name: Tag Version | ||
| run: npm --no-git-tag-version version prerelease --preid=${GITHUB_REF##*/}-${GITHUB_SHA:0:8} | ||
|
|
||
| - name: Configure Project-Level .npmrc File | ||
| run: npm config set --location=project @adzerk:registry=https://'${NPM_REGISTRY}' //'${NPM_REGISTRY}'/:_authToken='${NPM_SECRET}' |
There was a problem hiding this comment.
It looks like these rely on NPM_REGISTRY and NPM_SECRET, don't they? Am I right in assuming that this step won't have those values, as they've been moved into the step below instead of living at the top level?
There was a problem hiding this comment.
Normally yes, but what I've done is wrap the shell variables in single quotes as the actual values will be substituted in by npm when npm publish is run.
There was a problem hiding this comment.
That line creates a file called .npmrc with the contents:
@adzerk:registry=https://${NPM_REGISTRY}
//${NPM_REGISTRY}/:_authToken=${NPM_SECRET}
There was a problem hiding this comment.
npm publish then substitutes those values in from env variables when run
| } from './generated'; | ||
| RequiredError, | ||
| UserdbApi | ||
| } from '@adzerk/api-decision-js'; |
There was a problem hiding this comment.
I'm happy that you removed the generated code from the repo! Much cleaner and less confusing.
There was a problem hiding this comment.
thank you
honeycomb-cheesecake
deleted the
simonramzi/sc-48140/javascript-decision-sdk-ignores-some-fields
branch
Added the SkipFilters parameter to the sdk.