fix: Add cwd to support js-debug-adapter #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Jack-Barry, thanks for the PR. Lgtm. @MisanthropicBit, you were reviewing the issue #18. What do you think? |
|
Thanks for the PR Jack! @adrigzr LGTM too 🙂 Perhaps a test would be in order but I can also add one at a later time. |
|
@adrigzr do you know why the unit tests action would be hanging here? I'd like to get this merged, but not sure why that check hasn't resolved yet. @MisanthropicBit I can try and write up tests around this, could take a while for my smooth brain though |
|
@Jack-Barry, no idea, but I merged it! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #18
Adds the
cwdattribute to the debug config to allow for usingnvim-dapto debug tests